Attention is currently required from: Angel Pons, Christian Walter, Johnny Lin, Jonathan Zhang, Morgan Jang, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85805?usp=email )
Change subject: soc/intel/xeon_sp/skx: Enable x86_64
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85805/comment/62813d8c_438b5a30?usp... :
PS1, Line 13: Add support for x86_64 coreboot and confirm that all supported boards
`'occurence' may be misspelled - perhaps 'occurrence'?` […]
Done
File src/vendorcode/intel/fsp/fsp2_0/skylake_sp/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/85805/comment/a25842e9_82db12e4?usp... :
PS1, Line 513: VOID *SetupStructPtr;
Good point. Will update the commit message. It's both unused on coreboot and FSP side.
Done
https://review.coreboot.org/c/coreboot/+/85805/comment/0e4b8d1e_645fb016?usp... :
PS1, Line 272: UINT32 GpioTablePtr;
Silly idea: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85805?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8adac99e7600a708b596fd74b00669f4cb4e041b
Gerrit-Change-Number: 85805
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 30 Dec 2024 13:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com