Attention is currently required from: Cliff Huang, Tim Wawrzynczak, Paul Menzel.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62771 )
Change subject: mb/google/brya/vell: Move WWAN devices for vell
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62771/comment/4f064713_327659df
PS4, Line 9: This was to merge PCIe ACPI code to WWAN device.Also, RTD3 devices are add to overridetree.cb where WWAN is
: present for vell.
please reflow for 72 characters wide
Done
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62771/comment/d0ee6ac4_28896c7c
PS4, Line 168: # register "reset_delay_ms" = "1000"
nit: remove this
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62771
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If27abcf31ed948899bfaecbe8ef494fe8a80609b
Gerrit-Change-Number: 62771
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 18 Mar 2022 01:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment