Change in coreboot[master]: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt
Attention is currently required from: Robert Zieba, Chris Wang, Karthik Ramasubramanian, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63132 )
Change subject: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63132/comment/6a956efa_d28afd6a PS4, Line 16: SPD_SOURCES += $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/K4U6E3S4AB-MGCL.hex # ID = 9(0b1001) Parts = K4U6E3S4AB-MGCL
Since I saw that doesn't include that specific part number in the separated SPD data. […]
Yes we need to add new support in part_id_gen tool. This will take a few days. This change is needed to unblock the project. I'm going to +2 this change while we add support to part_id_gen in parallel (b/224884904). We will need to manually maintain this patch to this Makefile until part_id_gen is updated.
-
Rob Barnes (Code Review)