Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37887 )
Change subject: mb/intel/tglrvp : Add ACPI support for CNVi
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37887/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37887/3//COMMIT_MSG@7
PS3, Line 7: mb/intel/tglrvp : Add ACPI support for CNVi
Please remove the space before the colon.
Ack
https://review.coreboot.org/c/coreboot/+/37887/3//COMMIT_MSG@10
PS3, Line 10: Tigerlake
Tiger Lake
Ack
https://review.coreboot.org/c/coreboot/+/37887/3//COMMIT_MSG@10
PS3, Line 10: devices and methods on Tigerlake.
Should fit on one line.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66091374f8ebcb06457296252c9a8924734a7fa5
Gerrit-Change-Number: 37887
Gerrit-PatchSet: 4
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.corp-partner.google.com
Gerrit-CC: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Thu, 23 Jan 2020 06:48:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment