Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55540 )
Change subject: mb/lenovo/x230: Fix overridetrees not overriding ......................................................................
mb/lenovo/x230: Fix overridetrees not overriding
Any chip entry without a device node below them are silently dropped by sconfig. Copy the same device node from the devicetree to prevent this.
Change-Id: I778f6b2d980e78142ae12ef941e7d9bd1f753057 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/55540 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x230/variants/x230/overridetree.cb M src/mainboard/lenovo/x230/variants/x230s/overridetree.cb 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x230/variants/x230/overridetree.cb b/src/mainboard/lenovo/x230/variants/x230/overridetree.cb index 97e48b8..978d017 100644 --- a/src/mainboard/lenovo/x230/variants/x230/overridetree.cb +++ b/src/mainboard/lenovo/x230/variants/x230/overridetree.cb @@ -9,6 +9,7 @@ device pci 1f.0 on # LPC bridge chip ec/lenovo/h8 register "eventa_enable" = "0x01" + device pnp ff.2 on end end end # LPC Controller end diff --git a/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb b/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb index b2d0cf2..1c0efd3 100644 --- a/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb +++ b/src/mainboard/lenovo/x230/variants/x230s/overridetree.cb @@ -26,6 +26,7 @@ register "evente_enable" = "0x1d" # X230s only has BT on wlan card register "has_bdc_detection" = "0" + device pnp ff.2 on end end end # LPC Controller end