Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34547 )
Change subject: soc/intel/fsp_broadwell_de: Fix use of config_of() ......................................................................
soc/intel/fsp_broadwell_de: Fix use of config_of()
Change-Id: I96d423720fbe67c067373436ad250edf37939e99 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/fsp_broadwell_de/iou_complto.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/34547/1
diff --git a/src/soc/intel/fsp_broadwell_de/iou_complto.c b/src/soc/intel/fsp_broadwell_de/iou_complto.c index c50cbb4..f998d97 100644 --- a/src/soc/intel/fsp_broadwell_de/iou_complto.c +++ b/src/soc/intel/fsp_broadwell_de/iou_complto.c @@ -17,12 +17,14 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <soc/intel/fsp_broadwell_de/chip.h> +#include <soc/pci_devs.h>
#define DEVCTL2 0xb8
static void iou_init(struct device *dev) { - const config_t *config = config_of(dev); + /* Use config from device always present in static devicetree. */ + const config_t *config = config_of_path(SOC_DEV_FUNC); u16 devctl2;
/* pcie completion timeout
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34547 )
Change subject: soc/intel/fsp_broadwell_de: Fix use of config_of() ......................................................................
Patch Set 1: Code-Review+2
This change resolves current issue on mc_bdx1. So fine for me and I can abandon my devicetree-patch.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34547 )
Change subject: soc/intel/fsp_broadwell_de: Fix use of config_of() ......................................................................
Patch Set 1:
Please mention what problem this fixes, and maybe even the hash of the commit being fixed.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34547 )
Change subject: soc/intel/fsp_broadwell_de: Fix use of config_of() ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34547 )
Change subject: soc/intel/fsp_broadwell_de: Fix use of config_of() ......................................................................
soc/intel/fsp_broadwell_de: Fix use of config_of()
Change-Id: I96d423720fbe67c067373436ad250edf37939e99 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34547 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/soc/intel/fsp_broadwell_de/iou_complto.c 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved
diff --git a/src/soc/intel/fsp_broadwell_de/iou_complto.c b/src/soc/intel/fsp_broadwell_de/iou_complto.c index c50cbb4..f998d97 100644 --- a/src/soc/intel/fsp_broadwell_de/iou_complto.c +++ b/src/soc/intel/fsp_broadwell_de/iou_complto.c @@ -17,12 +17,14 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <soc/intel/fsp_broadwell_de/chip.h> +#include <soc/pci_devs.h>
#define DEVCTL2 0xb8
static void iou_init(struct device *dev) { - const config_t *config = config_of(dev); + /* Use config from device always present in static devicetree. */ + const config_t *config = config_of_path(SOC_DEV_FUNC); u16 devctl2;
/* pcie completion timeout
-
Kyösti Mälkki (Code Review) -
Martin Roth (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)