Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53922 )
Change subject: soc/amd/common/block/pci: Introduce struct pci_routing_info
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/amd_pci_util.h:
https://review.coreboot.org/c/coreboot/+/53922/comment/e823f63a_e971d9bd
PS3, Line 47: struct pci_routing_info {
Done
does the __packed go before or after the struct definition? i always put it before the definition and i vaguely remember that there was some problem in some part of coreboot due to putting it in the wrong place, but i might misremember
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a8d988d125f407f0aa7bc1722d432446aa9aff8
Gerrit-Change-Number: 53922
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Sat, 08 May 2021 16:49:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment