Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34678 )
Change subject: common/block/imc: Add Integrated Memory Controller (IMC) driver
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/imc/imc.c:
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/...
PS4, Line 106: return -1;
do we want to fail silently here?
Ack
https://review.coreboot.org/c/coreboot/+/34678/4/src/soc/intel/common/block/...
PS4, Line 147: goto cleanup;
another silent fail
well, this is just error indication. This is pretty common if you scan bus. You don't want error prints when you scan bus. I think caller should know better if it is a hard error or not
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbcda1c2273b9a5721fcd9470b4de182192779e7
Gerrit-Change-Number: 34678
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 20:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment