Attention is currently required from: Paul Menzel, Shelley Chen, Vamshi Krishna Gopal.
Poornima Tom has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79723?usp=email )
Change subject: mb/google/brox: Enable HDA Codec ALC256 ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79723/comment/3e8591f7_cbb4a6e5 : PS5, Line 7: Codec-ALC256
Remove the hyphen?
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/31e9a997_a6958d9a : PS5, Line 9: ALC 256
Remove the space?
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/9410e895_401cad0e : PS5, Line 9: Add verb table for the same.
How did you create this?
ALC256 file based on which the verb table generated is added in cross bug.
https://review.coreboot.org/c/coreboot/+/79723/comment/12b15eae_016c5ec4 : PS5, Line 11:
Please document the datasheet name and revision.
Done
https://review.coreboot.org/c/coreboot/+/79723/comment/883d30e0_ccda2d10 : PS5, Line 14: To verify HDA on Brox
Does that mean, you are going to test it?
Yes, It needs to be tested based on the board availability. Shelly is planning to test it next week.