Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33022
Change subject: intel/quark/storage_test.h: Drop external variable declaration ......................................................................
intel/quark/storage_test.h: Drop external variable declaration
These are only used where they are initially declared.
Change-Id: I0a81a945b771b6c29a170c479b9e72c98e8f3c5a Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/quark/include/soc/storage_test.h 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/33022/1
diff --git a/src/soc/intel/quark/include/soc/storage_test.h b/src/soc/intel/quark/include/soc/storage_test.h index 62c9e79..1c93f1c 100644 --- a/src/soc/intel/quark/include/soc/storage_test.h +++ b/src/soc/intel/quark/include/soc/storage_test.h @@ -48,9 +48,4 @@
#define LOG_ENTRIES 256
-extern struct log_entry log[LOG_ENTRIES]; -extern uint8_t log_index; -extern int log_full; -extern long log_start_time; - #endif /* __STORAGE_TEST_H__ */
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33022 )
Change subject: intel/quark/storage_test.h: Drop external variable declaration ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33022 )
Change subject: intel/quark/storage_test.h: Drop external variable declaration ......................................................................
intel/quark/storage_test.h: Drop external variable declaration
These are only used where they are initially declared.
Change-Id: I0a81a945b771b6c29a170c479b9e72c98e8f3c5a Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33022 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/soc/intel/quark/include/soc/storage_test.h 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/soc/intel/quark/include/soc/storage_test.h b/src/soc/intel/quark/include/soc/storage_test.h index 62c9e79..1c93f1c 100644 --- a/src/soc/intel/quark/include/soc/storage_test.h +++ b/src/soc/intel/quark/include/soc/storage_test.h @@ -48,9 +48,4 @@
#define LOG_ENTRIES 256
-extern struct log_entry log[LOG_ENTRIES]; -extern uint8_t log_index; -extern int log_full; -extern long log_start_time; - #endif /* __STORAGE_TEST_H__ */