Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55428 )
Change subject: tree-wide: Use mmio_resource64() and fixed_mem_resource64()
......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/emulation/qemu-i440fx/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121586):
https://review.coreboot.org/c/coreboot/+/55428/comment/346c39f4_07513de2
PS10, Line 79: fixed_mem_resource64(dev, idx++, list[i].address, list[i].length,
line over 96 characters
File src/soc/intel/broadwell/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121586):
https://review.coreboot.org/c/coreboot/+/55428/comment/a86f595a_80b29010
PS10, Line 340: mmio_resource64(dev, index++, mc_values[BGSM_REG], mc_values[TOLUD_REG] - mc_values[BGSM_REG]);
line over 96 characters
File src/soc/intel/denverton_ns/lpc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121586):
https://review.coreboot.org/c/coreboot/+/55428/comment/337fd7c3_c29fc698
PS10, Line 416: res = fixed_mem_resource64(dev, 0xda, DEFAULT_PCR_BASE, 16 * 1024 * 1024, IORESOURCE_STORED);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55428
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24a99e93b4067347c080ec025a49d141172817c6
Gerrit-Change-Number: 55428
Gerrit-PatchSet: 10
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 14 Jun 2021 10:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment