Change in ...coreboot[master]: medaitek: Add function to raise the CPU frequency

[Tristan Hsieh (Code Review)]

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32465

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

medaitek: Add function to raise the CPU frequency

Implement mt_pll_raise_ca53_freq() in MT8183 to raise the CPU frequency.
Move the function declaration to common header.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui

Change-Id: Ide8d767486d68177fa2bfbcc5b559879eca1bcda
Signed-off-by: Tristan Shieh 
---
M src/soc/mediatek/common/include/soc/pll_common.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8183/Makefile.inc
M src/soc/mediatek/mt8183/pll.c
4 files changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32465/1

diff --git a/src/soc/mediatek/common/include/soc/pll_common.h b/src/soc/mediatek/common/include/soc/pll_common.h
index 480371b..d0ffa86c 100644
--- a/src/soc/mediatek/common/include/soc/pll_common.h
+++ b/src/soc/mediatek/common/include/soc/pll_common.h
@@ -69,5 +69,6 @@
 void mux_set_sel(const struct mux *mux, u32 sel);
 int pll_set_rate(const struct pll *pll, u32 rate);
 void mt_pll_init(void);
+void mt_pll_raise_ca53_freq(u32 freq);

#endif
diff --git a/src/soc/mediatek/mt8173/include/soc/pll.h b/src/soc/mediatek/mt8173/include/soc/pll.h
index 4106d2a..480ffbf 100644
--- a/src/soc/mediatek/mt8173/include/soc/pll.h
+++ b/src/soc/mediatek/mt8173/include/soc/pll.h
@@ -292,7 +292,6 @@
 void mt_pll_post_init(void);
 void mt_pll_set_aud_div(u32 rate);
 void mt_pll_enable_ssusb_clk(void);
-void mt_pll_raise_ca53_freq(u32 freq);
 void mt_mem_pll_set_clk_cfg(void);
 void mt_mem_pll_config_pre(const struct mt8173_sdram_params *sdram_params);
 void mt_mem_pll_config_post(void);
diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc
index 3fce0a8..5392a9e 100644
--- a/src/soc/mediatek/mt8183/Makefile.inc
+++ b/src/soc/mediatek/mt8183/Makefile.inc
@@ -32,6 +32,7 @@
 romstage-y += mt8183.c
 romstage-y += ../common/gpio.c gpio.c
 romstage-y += ../common/mmu_operations.c mmu_operations.c
+romstage-y += ../common/pll.c pll.c
 romstage-y += ../common/pmic_wrap.c pmic_wrap.c mt6358.c
 romstage-y += ../common/rtc.c rtc.c
 romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c
diff --git a/src/soc/mediatek/mt8183/pll.c b/src/soc/mediatek/mt8183/pll.c
index 61aa2de..c32e6bc 100644
--- a/src/soc/mediatek/mt8183/pll.c
+++ b/src/soc/mediatek/mt8183/pll.c
@@ -357,3 +357,7 @@
    /* enable [14] dramc_pll104m_ck */
    setbits_le32(&mtk_topckgen->clk_misc_cfg_0, 1 << 14);
 }
+
+void mt_pll_raise_ca53_freq(u32 freq) {
+	pll_set_rate(&plls[APMIXED_ARMPLL_LL], freq);
+}

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c 
File src/soc/mediatek/mt8183/pll.c:

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c@361 
PS1, Line 361: void mt_pll_raise_ca53_freq(u32 freq) {
open brace '{' following function definitions go on the next line

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c 
File src/soc/mediatek/mt8183/pll.c:

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c@361 
PS1, Line 361: void mt_pll_raise_ca53_freq(u32 freq) {
open brace '{' following function definitions go on the next line

[Tristan Hsieh (Code Review)]

Hello Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Weiyi Lu, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32465

to look at the new patch set (#2).

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

medaitek: Add function to raise the CPU frequency

Implement mt_pll_raise_ca53_freq() in MT8183 to raise the CPU frequency.
Move the function declaration to common header.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui

Change-Id: Ide8d767486d68177fa2bfbcc5b559879eca1bcda
Signed-off-by: Tristan Shieh 
---
M src/soc/mediatek/common/include/soc/pll_common.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8173/pll.c
M src/soc/mediatek/mt8183/Makefile.inc
M src/soc/mediatek/mt8183/pll.c
5 files changed, 9 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32465/2

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

Patch Set 2: Code-Review+1

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: medaitek: Add function to raise the CPU frequency
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32465/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32465/2//COMMIT_MSG@7 
PS2, Line 7: medaitek
nit: mediatek

Change in ...coreboot[master]: mediatek: Add function to raise the CPU frequency

[Tristan Hsieh (Code Review)]

Hello Julius Werner, You-Cheng Syu, Hung-Te Lin, build bot (Jenkins), Weiyi Lu, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32465

to look at the new patch set (#3).

Change subject: mediatek: Add function to raise the CPU frequency
......................................................................

mediatek: Add function to raise the CPU frequency

Implement mt_pll_raise_ca53_freq() in MT8183 to raise the CPU frequency.
Move the function declaration to common header.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui

Change-Id: Ide8d767486d68177fa2bfbcc5b559879eca1bcda
Signed-off-by: Tristan Shieh 
---
M src/soc/mediatek/common/include/soc/pll_common.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8173/pll.c
M src/soc/mediatek/mt8183/Makefile.inc
M src/soc/mediatek/mt8183/pll.c
5 files changed, 9 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32465/3

Change in ...coreboot[master]: mediatek: Add function to raise the CPU frequency

[Tristan Hsieh (Code Review)]

Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: mediatek: Add function to raise the CPU frequency
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/#/c/32465/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32465/2//COMMIT_MSG@7 
PS2, Line 7: medaitek
> nit: mediatek

Done

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c 
File src/soc/mediatek/mt8183/pll.c:

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c@361 
PS1, Line 361: void mt_pll_raise_ca53_freq(u32 freq) {
> open brace '{' following function definitions go on the next line

Done

https://review.coreboot.org/#/c/32465/1/src/soc/mediatek/mt8183/pll.c@361 
PS1, Line 361: void mt_pll_raise_ca53_freq(u32 freq) {
> open brace '{' following function definitions go on the next line

Done

Change in ...coreboot[master]: mediatek: Add function to raise the CPU frequency

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32465 )

Change subject: mediatek: Add function to raise the CPU frequency
......................................................................

mediatek: Add function to raise the CPU frequency

Implement mt_pll_raise_ca53_freq() in MT8183 to raise the CPU frequency.
Move the function declaration to common header.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui

Change-Id: Ide8d767486d68177fa2bfbcc5b559879eca1bcda
Signed-off-by: Tristan Shieh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32465
Tested-by: build bot (Jenkins) 
Reviewed-by: Hung-Te Lin 
Reviewed-by: Julius Werner 
---
M src/soc/mediatek/common/include/soc/pll_common.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8173/pll.c
M src/soc/mediatek/mt8183/Makefile.inc
M src/soc/mediatek/mt8183/pll.c
5 files changed, 9 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved
  Hung-Te Lin: Looks good to me, but someone else must approve

diff --git a/src/soc/mediatek/common/include/soc/pll_common.h b/src/soc/mediatek/common/include/soc/pll_common.h
index 480371b..d0ffa86c 100644
--- a/src/soc/mediatek/common/include/soc/pll_common.h
+++ b/src/soc/mediatek/common/include/soc/pll_common.h
@@ -69,5 +69,6 @@
 void mux_set_sel(const struct mux *mux, u32 sel);
 int pll_set_rate(const struct pll *pll, u32 rate);
 void mt_pll_init(void);
+void mt_pll_raise_ca53_freq(u32 freq);

#endif
diff --git a/src/soc/mediatek/mt8173/include/soc/pll.h b/src/soc/mediatek/mt8173/include/soc/pll.h
index 4106d2a..480ffbf 100644
--- a/src/soc/mediatek/mt8173/include/soc/pll.h
+++ b/src/soc/mediatek/mt8173/include/soc/pll.h
@@ -292,7 +292,6 @@
 void mt_pll_post_init(void);
 void mt_pll_set_aud_div(u32 rate);
 void mt_pll_enable_ssusb_clk(void);
-void mt_pll_raise_ca53_freq(u32 freq);
 void mt_mem_pll_set_clk_cfg(void);
 void mt_mem_pll_config_pre(const struct mt8173_sdram_params *sdram_params);
 void mt_mem_pll_config_post(void);
diff --git a/src/soc/mediatek/mt8173/pll.c b/src/soc/mediatek/mt8173/pll.c
index c59fa3f..7eb12b1 100644
--- a/src/soc/mediatek/mt8173/pll.c
+++ b/src/soc/mediatek/mt8173/pll.c
@@ -432,7 +432,8 @@
    }
 }

-void mt_pll_raise_ca53_freq(u32 freq) {
+void mt_pll_raise_ca53_freq(u32 freq)
+{
    pll_set_rate(&plls[APMIXED_ARMCA7PLL], freq); /* freq in Hz */
 }

diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.inc
index 3fce0a8..5392a9e 100644
--- a/src/soc/mediatek/mt8183/Makefile.inc
+++ b/src/soc/mediatek/mt8183/Makefile.inc
@@ -32,6 +32,7 @@
 romstage-y += mt8183.c
 romstage-y += ../common/gpio.c gpio.c
 romstage-y += ../common/mmu_operations.c mmu_operations.c
+romstage-y += ../common/pll.c pll.c
 romstage-y += ../common/pmic_wrap.c pmic_wrap.c mt6358.c
 romstage-y += ../common/rtc.c rtc.c
 romstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c
diff --git a/src/soc/mediatek/mt8183/pll.c b/src/soc/mediatek/mt8183/pll.c
index 8608b4a..07ce660 100644
--- a/src/soc/mediatek/mt8183/pll.c
+++ b/src/soc/mediatek/mt8183/pll.c
@@ -369,3 +369,8 @@
    /* enable mtkaif 26m clock */
    setbits_le32(&mt8183_infracfg->module_sw_cg_2_clr, 1 << 4);
 }
+
+void mt_pll_raise_ca53_freq(u32 freq)
+{
+	pll_set_rate(&plls[APMIXED_ARMPLL_LL], freq);
+}