Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Martin Roth, Karthik Ramasubramanian, EricR Lai, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52304 )
Change subject: soc/amd/common/block/acpi: Fix the config to build gpio library
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/block/acpi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52304/comment/ee3687eb_682ad461
PS3, Line 12: CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_GPIO
It seems our symbols are long enough that it affects readability :/
https://review.coreboot.org/c/coreboot/+/52304/comment/e84432fd_fcce2cf7
PS3, Line 12: ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI) += pm_state.c
: ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI) += tables.c
Why not leave these where they were, and avoid having to use $(CONFIG_S...)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c1dab421cb2feb7346718e1e23ed9d4a21d40cc
Gerrit-Change-Number: 52304
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Apr 2021 18:46:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment