Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Felix Singer, Patrick Rudolph.
Michał Zieliński has posted comments on this change by Michał Zieliński. ( https://review.coreboot.org/c/coreboot/+/67666?usp=email )
Change subject: mb/hp: Add HP Compaq 8300 Elite SFF ......................................................................
Patch Set 8:
(5 comments)
Patchset:
PS5:
Needs a rebase on the main branch too.
Done
File src/mainboard/hp/compaq_8300_elite_sff/Kconfig:
https://review.coreboot.org/c/coreboot/+/67666/comment/6bfe6f7d_9bcc60be?usp... : PS5, Line 33: int
Avoid retyping, remove.
Done
https://review.coreboot.org/c/coreboot/+/67666/comment/331e7eb3_f234d1e1?usp... : PS5, Line 37: int
Avoid retyping, remove.
Done
File src/mainboard/hp/compaq_8300_elite_sff/Makefile.inc:
PS5:
Needs to be renamed to Makefile. […]
Done
File src/mainboard/hp/compaq_8300_elite_sff/early_init.c:
https://review.coreboot.org/c/coreboot/+/67666/comment/c5f16528_a76c3623?usp... : PS5, Line 11: const struct southbridge_usb_port mainboard_usb_ports[] = { : { 1, 0, 0 }, : { 1, 0, 0 }, : { 1, 0, 1 }, : { 1, 0, 1 }, : { 1, 0, 2 }, : { 1, 0, 2 }, : { 1, 0, 3 }, : { 1, 0, 3 }, : { 1, 1, 4 }, : { 1, 0, 4 }, : { 1, 0, 6 }, : { 1, 0, 5 }, : { 1, 0, 5 }, : { 1, 0, 6 }, : };
USB ports are configured in devicetree now. Please have a look at hp/snb_ivb_desktops.
Done