Maciej Pijanowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82692?usp=email )
Change subject: util/smmstoretool: explain what happens when no store is found ......................................................................
util/smmstoretool: explain what happens when no store is found
We are going to expose ths tool to end users, and want to take care that the presented information can be consumed by them.
The current code simply prints below warnings if we use release binary available for end-user to download:
No firmware volume header present No valid firmware volume was found
It will be concerning and not clear to end users, they might not understant why it happens, what are the implciations, and whether it is something that they should worry about.
This commit tries to explain what actually happens here.
Change-Id: Iaa2678f5ae7c243811484c0567ced97ae0b3fc0a Signed-off-by: Maciej Pijanowski maciej.pijanowski@3mdeb.com --- M util/smmstoretool/storage.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/82692/1
diff --git a/util/smmstoretool/storage.c b/util/smmstoretool/storage.c index 8a02384..b077a47 100644 --- a/util/smmstoretool/storage.c +++ b/util/smmstoretool/storage.c @@ -50,6 +50,12 @@ goto error; }
+ fprintf(stderr, + "Variable store has not been found in the binary and will " + "be initialized now.\nIt is expected if release binary is " + "used, as variable store normally is initialized on the " + "first boot of the platform.\n"); + if (!fv_init(storage->region)) { fprintf(stderr, "Failed to create variable store in "%s"\n",