Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572 ......................................................................
Patch Set 4:
(4 comments)
Patch Set 4: Code-Review+1
(4 comments)
I'll take care of the comments someday. I would prefer to fix leaf blower syndrome first, though.
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@7 PS4, Line 7: mainboard
mb/acer:
The "acer" folder is not there just yet (or at least it wasn't last time I checked), so the change has to add it. It's not a big deal.
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@19 PS4, Line 19: tianocore
TianoCore
But its folder is named "tianocore" ?
(I just can't stand the capitalized spelling)
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@19 PS4, Line 19: Linux
Which version?
Honestly, I have no idea.
Since my OCD loathes that question, I'll just put "Arch Linux", which has no version numbers >:)
I mean, I don't want to have to keep updating that number while I wait for my executive function to recharge.
https://review.coreboot.org/c/coreboot/+/38978/4//COMMIT_MSG@24 PS4, Line 24: need
needs?
It's actually plural: (things that) are not working or need testing.