Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45196 )
Change subject: mb/google/dedede: Enable SaGv support
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@7
PS4, Line 7: SaGv support
We (and by this I mean "you" ;-) ) can look for better ways to implement the toggle, but for now thi […]
Alright, thanks for confirming. So, I can make it controllable through Kconfig, but allow mainboards to specify the default value for SaGv.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f60aad031ce9dfe23e54426753311c35db46c05
Gerrit-Change-Number: 45196
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 09:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment