Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35318 )
Change subject: soc/fsp_broadwell_de: Use DIMM numbers relative to channel ......................................................................
soc/fsp_broadwell_de: Use DIMM numbers relative to channel
Currently "DIMM numbers" increase monotonically for all the channels. However, commonly DIMMS are numerated on per-channel basis. This change makes numeration match the convention.
TEST=on OCP monolake, run dmidecode tool and see that "Locator" field matches expectation.
Change-Id: I3e7858545471867a0210e1b9ef646529b8e2a31c Signed-off-by: Andrey Petrov anpetrov@fb.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35318 Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: David Hendricks david.hendricks@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/fsp_broadwell_de/romstage/memory.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Patrick Rudolph: Looks good to me, approved
diff --git a/src/soc/intel/fsp_broadwell_de/romstage/memory.c b/src/soc/intel/fsp_broadwell_de/romstage/memory.c index 7574c5f..afbf97b 100644 --- a/src/soc/intel/fsp_broadwell_de/romstage/memory.c +++ b/src/soc/intel/fsp_broadwell_de/romstage/memory.c @@ -54,7 +54,7 @@ dimm_attr dimm = {0}; u8 *spd_data = blk.spd_array[index]; if (spd_decode_ddr4(&dimm, spd_data) == SPD_STATUS_OK) - spd_add_smbios17_ddr4(channel, index, dclk_mhz, &dimm); + spd_add_smbios17_ddr4(channel, slot, dclk_mhz, &dimm); index++; } }