Change in coreboot[master]: fsp/fsp2_0/coffeelake: Update CFL FSP headers - coreboot-gerrit

23 Aug 2018


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28286 )
Change subject: fsp/fsp2_0/coffeelake: Update CFL FSP headers
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28286/2/src/vendorcode/intel/fsp/fsp2_0/coff...
File src/vendorcode/intel/fsp/fsp2_0/coffeelake/CFLFspHeaderUpdate.sh:
PS2: 
I wonder if it's possible to generalize the script a bit and put it in util/scripts?
eg. update-fsp-headers.sh CoffeeLake -> loads from $1FspBinPkg and stores in src/vendorcode/fsp/fsp2_0/$(echo $1 | tr '[A-Z]' '[a-z]')/
-- 
To view, visit https://review.coreboot.org/28286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656da83e9042642576b785643e423ba47da8dd73
Gerrit-Change-Number: 28286
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Aug 2018 14:32:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes