HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
src/ec: Add missing "set_resources = noop_set_resources"
Change-Id: I4acfb9d9911e251a494b6d35d76226c06e7858d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/compal/ene932/ec.c M src/ec/quanta/ene_kb3940q/ec.c M src/ec/quanta/it8518/ec.c M src/ec/roda/it8518/ec.c 4 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/40256/1
diff --git a/src/ec/compal/ene932/ec.c b/src/ec/compal/ene932/ec.c index 15751df..b6a6f20 100644 --- a/src/ec/compal/ene932/ec.c +++ b/src/ec/compal/ene932/ec.c @@ -135,6 +135,7 @@ static struct device_operations ops = { .init = ene932_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c index 4e8bde1..9e8a682 100644 --- a/src/ec/quanta/ene_kb3940q/ec.c +++ b/src/ec/quanta/ene_kb3940q/ec.c @@ -145,6 +145,7 @@ static struct device_operations ops = { .init = ene_kb3940q_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c index ccf2d45..0e52cd2 100644 --- a/src/ec/quanta/it8518/ec.c +++ b/src/ec/quanta/it8518/ec.c @@ -159,6 +159,7 @@ static struct device_operations ops = { .init = it8518_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/roda/it8518/ec.c b/src/ec/roda/it8518/ec.c index b529e76..695de45 100644 --- a/src/ec/roda/it8518/ec.c +++ b/src/ec/roda/it8518/ec.c @@ -47,6 +47,7 @@ static struct device_operations ops = { .init = it8518_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = {
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
Patch Set 1:
Thx
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40256/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40256/1//COMMIT_MSG@7 PS1, Line 7: missing IMO, not "missing" but "warranted". It's not that it's always missing a no-op, no-op could also be an error. But in this case (read_resources being a no-op too) we can be rather sure that it's ok.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
src/ec: Add missing "set_resources = noop_set_resources"
Change-Id: I4acfb9d9911e251a494b6d35d76226c06e7858d6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40256 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/ec/compal/ene932/ec.c M src/ec/quanta/ene_kb3940q/ec.c M src/ec/quanta/it8518/ec.c M src/ec/roda/it8518/ec.c 4 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/src/ec/compal/ene932/ec.c b/src/ec/compal/ene932/ec.c index 93d9154..f0d83a7 100644 --- a/src/ec/compal/ene932/ec.c +++ b/src/ec/compal/ene932/ec.c @@ -123,6 +123,7 @@ static struct device_operations ops = { .init = ene932_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c index 4959db1..db1a04b 100644 --- a/src/ec/quanta/ene_kb3940q/ec.c +++ b/src/ec/quanta/ene_kb3940q/ec.c @@ -133,6 +133,7 @@ static struct device_operations ops = { .init = ene_kb3940q_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c index 9cb3755..bd82ecc 100644 --- a/src/ec/quanta/it8518/ec.c +++ b/src/ec/quanta/it8518/ec.c @@ -147,6 +147,7 @@ static struct device_operations ops = { .init = it8518_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = { diff --git a/src/ec/roda/it8518/ec.c b/src/ec/roda/it8518/ec.c index f4a2758..07b61f5 100644 --- a/src/ec/roda/it8518/ec.c +++ b/src/ec/roda/it8518/ec.c @@ -36,6 +36,7 @@ static struct device_operations ops = { .init = it8518_init, .read_resources = noop_read_resources, + .set_resources = noop_set_resources, };
static struct pnp_info pnp_dev_info[] = {
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40256 )
Change subject: src/ec: Add missing "set_resources = noop_set_resources" ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2239 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2238 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2237
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)