Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email )
Change subject: soc/mediatek: Add common implmentation to configure display
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/geralt/panel.h:
https://review.coreboot.org/c/coreboot/+/79776/comment/8aecc54f_6736e923 :
PS1, Line 23: struct panel_description *get_active_panel(void);
If so, do you suggest passing `struct panel_description panl` to `mtk_display_init` (configure_displ […]
That's a good question. I admit I didn't think of that. For now, I have no strong opinion, so I'm fine with your existing patchset. It's up to you (if the declaration is kept here, then I think we'll need to pass `panel` to `mtk_display_init()`).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79776?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f
Gerrit-Change-Number: 79776
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 08 Jan 2024 08:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment