Change in coreboot[master]: [UNTESTED] mb/amd/mandolin: add missing SPI configuration to devicetree
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: [UNTESTED] mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
[UNTESTED] mb/amd/mandolin: add missing SPI configuration to devicetree
BUG=b:169644059 BRANCH=zork
Change-Id: I2c7043c174dcf4501776a03b7689d8a20c214afb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/45830/1
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb index 7ccec27..3de5812 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb @@ -99,6 +99,15 @@ register "usb_port_overcurrent_pin[4]" = "USB_OC_PIN_0" register "usb_port_overcurrent_pin[5]" = "USB_OC_PIN_0"
+ # SPI Configuration + register "common_config.spi_config" = "{ + .normal_speed = SPI_SPEED_33M, /* MHz */ + .fast_speed = SPI_SPEED_66M, /* MHz */ + .altio_speed = SPI_SPEED_33M, /* MHz */ + .tpm_speed = SPI_SPEED_33M, /* MHz */ + .read_mode = SPI_READ_MODE_QUAD114, + }" + # eSPI Configuration register "common_config.espi_config" = "{ .std_io_decode_bitmap = ESPI_DECODE_IO_0X60_0X64_EN,
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: [UNTESTED] mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
Patch Set 1: Code-Review+1
Yep, works. Change the commit message and we're good.
Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: [UNTESTED] mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Marshall Dawson, Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45830
to look at the new patch set (#2).
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
mb/amd/mandolin: add missing SPI configuration to devicetree
BUG=b:169644059 BRANCH=zork
Change-Id: I2c7043c174dcf4501776a03b7689d8a20c214afb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/45830/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45830/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45830/2//COMMIT_MSG@8 PS2, Line 8: What is the result of the change. The board boots now?
Hello build bot (Jenkins), Marshall Dawson, Matt Papageorge,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45830
to look at the new patch set (#3).
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
mb/amd/mandolin: add missing SPI configuration to devicetree
This fixes the board not booting reliably when running from flash without the EM100 option selected during build time. Selecting EM100 mode overrides the settings, so when testing with an EM100 I didn't run into this issue.
BUG=b:169644059 BRANCH=zork
Change-Id: I2c7043c174dcf4501776a03b7689d8a20c214afb Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/45830/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45830/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45830/2//COMMIT_MSG@8 PS2, Line 8:
What is the result of the change. […]
yes, before the non-em100 configuration was unstable. i've added that to the commit message
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
Patch Set 3: Code-Review+1
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45830 )
Change subject: mb/amd/mandolin: add missing SPI configuration to devicetree ......................................................................
mb/amd/mandolin: add missing SPI configuration to devicetree
This fixes the board not booting reliably when running from flash without the EM100 option selected during build time. Selecting EM100 mode overrides the settings, so when testing with an EM100 I didn't run into this issue.
BUG=b:169644059 BRANCH=zork
Change-Id: I2c7043c174dcf4501776a03b7689d8a20c214afb Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/45830 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Matt Papageorge matthewpapa07@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Marshall Dawson: Looks good to me, approved Matt Papageorge: Looks good to me, but someone else must approve
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb index 7ccec27..3de5812 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb @@ -99,6 +99,15 @@ register "usb_port_overcurrent_pin[4]" = "USB_OC_PIN_0" register "usb_port_overcurrent_pin[5]" = "USB_OC_PIN_0"
+ # SPI Configuration + register "common_config.spi_config" = "{ + .normal_speed = SPI_SPEED_33M, /* MHz */ + .fast_speed = SPI_SPEED_66M, /* MHz */ + .altio_speed = SPI_SPEED_33M, /* MHz */ + .tpm_speed = SPI_SPEED_33M, /* MHz */ + .read_mode = SPI_READ_MODE_QUAD114, + }" + # eSPI Configuration register "common_config.espi_config" = "{ .std_io_decode_bitmap = ESPI_DECODE_IO_0X60_0X64_EN,
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)
-
Matt Papageorge (Code Review)
-
Paul Menzel (Code Review)