Luca Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86372?usp=email )
Change subject: UPSTREAM: mb/trulo/var/pujjolo: Create pujjolo variant ......................................................................
UPSTREAM: mb/trulo/var/pujjolo: Create pujjolo variant
Create the pujjolo variant of nissa reference board by copying the template files to a new directory named for the variant.
Due to new_variant.py limitation that repo can no longer be used in inside, created this CL manually following google suggestion.
BUG=b:395763555 TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_PUJJOLO
Change-Id: I9a5ea59c3ff5f5fb1e2ef44e2cee6e7b117d9347 Signed-off-by: Luca Lai luca.lai@lcfc.corp-partner.google.com --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/pujjolo/include/variant/ec.h A src/mainboard/google/brya/variants/pujjolo/include/variant/gpio.h A src/mainboard/google/brya/variants/pujjolo/memory/Makefile.mk A src/mainboard/google/brya/variants/pujjolo/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/pujjolo/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/pujjolo/overridetree.cb 8 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/86372/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 58b8922..81cdaab 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -466,6 +466,12 @@ select DRIVERS_AUDIO_SOF select SOC_INTEL_TWINLAKE
+config BOARD_GOOGLE_PUJJOLO + select BOARD_GOOGLE_BASEBOARD_TRULO + select CHROMEOS_WIFI_SAR if CHROMEOS + select DRIVERS_GENERIC_GPIO_KEYS + select SOC_INTEL_TWINLAKE + config BOARD_GOOGLE_QUANDISO select BOARD_GOOGLE_BASEBOARD_NISSA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -979,6 +985,7 @@ default "Pujjoga" if BOARD_GOOGLE_PUJJOGA default "Telith" if BOARD_GOOGLE_TELITH default "Pujjogatwin" if BOARD_GOOGLE_PUJJOGATWIN + default "Pujjolo" if BOARD_GOOGLE_PUJJOLO
config VARIANT_DIR default "agah" if BOARD_GOOGLE_AGAH diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 50bfaef..ca0c4e3 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -212,6 +212,9 @@ config BOARD_GOOGLE_PUJJOGATWIN bool "-> Pujjogatwin"
+config BOARD_GOOGLE_PUJJOLO + bool "-> Pujjolo" + config BOARD_GOOGLE_ORISA bool "-> Orisa"
diff --git a/src/mainboard/google/brya/variants/pujjolo/include/variant/ec.h b/src/mainboard/google/brya/variants/pujjolo/include/variant/ec.h new file mode 100644 index 0000000..3b7c04b --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjolo/include/variant/ec.h @@ -0,0 +1,8 @@ +* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/pujjolo/include/variant/gpio.h b/src/mainboard/google/brya/variants/pujjolo/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjolo/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/pujjolo/memory/Makefile.mk b/src/mainboard/google/brya/variants/pujjolo/memory/Makefile.mk new file mode 100644 index 0000000..eace2e4 --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjolo/memory/Makefile.mk @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# This is an auto-generated file. Do not edit!! +# Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder diff --git a/src/mainboard/google/brya/variants/pujjolo/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/pujjolo/memory/dram_id.generated.txt new file mode 100644 index 0000000..a000b55 --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjolo/memory/dram_id.generated.txt @@ -0,0 +1,2 @@ +DRAM Part Name ID to assign + diff --git a/src/mainboard/google/brya/variants/pujjolo/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/pujjolo/memory/mem_parts_used.txt new file mode 100644 index 0000000..2499005 --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjolo/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.mk and dram_id.generated.txt by running the +# part_id_gen tool from util/spd_tools. +# See util/spd_tools/README.md for more details and instructions. + +# Part Name diff --git a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb new file mode 100644 index 0000000..4f2c04a --- /dev/null +++ b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/alderlake + + device domain 0 on + end + +end
-
Luca Lai (Code Review)