Adrian-Ken Rueegsegger has posted comments on this change. ( https://review.coreboot.org/21206 )
Change subject: linux pci: Add dummy PCI access for shared contracts ......................................................................
Patch Set 1:
(1 comment)
Instead of faking an access on Linux another potential approach could be to explicitly specify the global contracts and accept/justify the warning in the Linux implementation using pragma Annotate (GNATprove).
Have not tested it and will result in more code due to contracts. On the other hand one would avoid the automatic contract generation...
https://review.coreboot.org/#/c/21206/1/common/linux/hw-pci-dev.adb File common/linux/hw-pci-dev.adb:
https://review.coreboot.org/#/c/21206/1/common/linux/hw-pci-dev.adb@44 PS1, Line 44: package Dummy is Wrapping the procedure in a Dummy package is not necessary. Is there a particular reason for it?
-
Adrian-Ken Rueegsegger (Code Review)