Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52893 )
Change subject: include/console: Align ramstage Boot State Machine postcodes
......................................................................
Patch Set 1:
(1 comment)
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52893/comment/443e6550_6828c9d2
PS1, Line 182: 0x79
Yes, i was adding 0x7c for POST_PRE_HARDWAREMAIN, submitting the CL, hopes that fine, because we hav […]
I think it is okay. Only thing I would be worried about is if anyone is using any scripts/tests that look for that particular post code. But, then those scripts would really be checking for post code at incorrect point in boot. Let's make sure that the detail is properly captured in the commit message of the new CL so that people understand the impact of the change. Thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e03159fdf07a73f5f8eec1bbf32fcb47dd4af84
Gerrit-Change-Number: 52893
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 04 May 2021 18:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment