Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: arch/x86: Add symbols for CAR MTRRs in linker script
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30872/1/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/#/c/30872/1/src/arch/x86/car.ld@105
PS1, Line 105: _car_mtrr_size = (_car_mtrr_end - _car_mtrr_start);
I think it would make sense to check for MTRR alignment here. It would allow to catch bad Kconfig setups. It could be some AMD boards have unaligned CAR regions due to using fixed MTRR's.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef3546d2bfea2d4d8f87aaf8376e5566fd6aaa
Gerrit-Change-Number: 30872
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 12 Jan 2019 11:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment