Attention is currently required from: Felix Singer, Nico Huber, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Michael Niewöhner, Marcello Sylvester Bauer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 )
Change subject: [RFC] util/liveiso: Add NixOS config for a testing live system
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50194/comment/cd4ec6b6_f402fa17
PS4, Line 19: a variant with Gnome Shell
As far as I can tell, the current inception of the script doesn't include any graphical environment. It would be nice to mention so in the commit message.
Patchset:
PS4:
As discussed on IRC, persistence would be very useful to have.
File util/liveiso/console.nix:
https://review.coreboot.org/c/coreboot/+/50194/comment/2dee02fa_0c5905f1
PS4, Line 54: environment.systemPackages = with pkgs; [
Would be nice to include msr-tools or (preferably) https://github.com/adurbin/iotools as well
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Gerrit-Change-Number: 50194
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Comment-Date: Mon, 01 Feb 2021 14:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment