build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: mainboard/lenovo/t410: Add new port ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... PS16, Line 140: unsigned i; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/smihandler.c:
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... PS16, Line 34: switch (smif) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... PS16, Line 37: udelay(250000); long udelay - prefer mdelay; see arch/arm/include/asm/delay.h
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... PS16, Line 70: switch (event) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/11791/16/src/mainboard/lenovo/t410/... PS16, Line 97: switch (data) { switch and case should be at the same indent