View Change

5 comments:

• File src/mainboard/lenovo/t410/romstage.c:

  • Patch Set #16, Line 140: unsigned i;

    Prefer 'unsigned int' to bare use of 'unsigned'

• File src/mainboard/lenovo/t410/smihandler.c:

  • Patch Set #16, Line 34: switch (smif) {

    switch and case should be at the same indent

  • Patch Set #16, Line 37: udelay(250000);

    long udelay - prefer mdelay; see arch/arm/include/asm/delay.h

  • Patch Set #16, Line 70: switch (event) {

    switch and case should be at the same indent

  • Patch Set #16, Line 97: switch (data) {

    switch and case should be at the same indent

To view, visit change 11791. To unsubscribe, or for help writing mail filters, visit settings.