Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Add ability to verify SPI DMA hardware - coreboot-gerrit

3 May 2022


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Paul Menzel, Rob Barnes, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56322 )
Change subject: soc/amd/common/block/lpc/spi_dma: Add ability to verify SPI DMA hardware
......................................................................
Patch Set 7:
(1 comment)
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/56322/comment/fcc80c86_d50a4ee8 
PS7, Line 127: 		memset(transaction->destination, 0xFC, transaction->transfer_size);
...
0xFC magic number?
Just a poison value so the `memcmp` fill fail.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56322
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dd54cab86ad31b135a93d4667df346c60357337
Gerrit-Change-Number: 56322
Gerrit-PatchSet: 7
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 May 2022 14:36:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Gerrit-MessageType: comment