Attention is currently required from: Patrick Rudolph, Angel Pons, Julius Werner, Arthur Heymans.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63725 )
Change subject: cpu/x86/64bit: Generate static page tables from an assembly file
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/63725/comment/f4aaaf8d_ebcc48d2
PS3, Line 27: .quad _GEN_PAGE(0x200000 * 0)
Maybe something like this could work: […]
Nice, I didn't know you could use `.`.
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63725/comment/9fef4543_649eda4d
PS3, Line 7: CONFIG_ARCH_BOOTBLOCK_X86_64
Done
that is a good question... We have `VBOOT_STARTS_BEFORE_BOOTBLOCK` default to `y`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e31b701a2584268c85d327bf139953213899e3
Gerrit-Change-Number: 63725
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 21 Apr 2022 14:43:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment