Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30320 )
Change subject: sb/intel/i82801gx: Implement PCIe coalescing
......................................................................
Patch Set 12: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/30320/12/src/southbridge/intel/i82801gx/pcie...
File src/southbridge/intel/i82801gx/pcie.c:
https://review.coreboot.org/#/c/30320/12/src/southbridge/intel/i82801gx/pcie...
PS12, Line 30: int coalesce;
Caching `coalesce` doesn't seem necessary as you can also read it
from `config` when checking `rpc.ports[0].enable`.
https://review.coreboot.org/#/c/30320/12/src/southbridge/intel/i82801gx/pcie...
PS12, Line 125: struct device *dev = pcidev_path_on_root(PCI_DEVFN(31, 0));
same as `pcidev_on_root(31, 0)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30320
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d7ddef96e4f45e163f7017175398a0938a18273
Gerrit-Change-Number: 30320
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Sun, 13 Jan 2019 22:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment