Change in coreboot[master]: superio/smsc/sch5147/acpi: Convert superio.asl to ASL 2.0 syntax

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45992 )

Change subject: superio/smsc/sch5147/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

superio/smsc/sch5147/acpi: Convert superio.asl to ASL 2.0 syntax

Change-Id: I509b76dbdbdee8a6287fc7d877c9f6e3c6a9068b
Signed-off-by: Elyes HAOUAS 
---
M src/superio/smsc/sch5147/acpi/superio.asl
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45992/1

diff --git a/src/superio/smsc/sch5147/acpi/superio.asl b/src/superio/smsc/sch5147/acpi/superio.asl
index a8a24a5..d5040e7 100644
--- a/src/superio/smsc/sch5147/acpi/superio.asl
+++ b/src/superio/smsc/sch5147/acpi/superio.asl
@@ -124,7 +124,7 @@
    Method (_DIS)
    {
    	ENTER_CONFIG_MODE (SUPERIO_KBC_LDN)
-		  Store (Zero, PNP_DEVICE_ACTIVE)
+		  PNP_DEVICE_ACTIVE = 0
    	EXIT_CONFIG_MODE ()
    	#if defined(SUPERIO_KBC_PS2LDN)
    	Notify (SUPERIO_ID(PS2, SUPERIO_KBC_PS2LDN), 1)
@@ -169,7 +169,7 @@
    	})
    	ENTER_CONFIG_MODE (SUPERIO_KBC_LDN)
    	  PNP_WRITE_IRQ(PNP_IRQ0, Arg0, IR0)
-		  Store (One, PNP_DEVICE_ACTIVE)
+		  PNP_DEVICE_ACTIVE = 1
    	EXIT_CONFIG_MODE ()
    	Notify (SUPERIO_ID(PS2, SUPERIO_KBC_LDN), 1)
    }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45992 )

Change subject: superio/smsc/sch5147/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45992 )

Change subject: superio/smsc/sch5147/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

superio/smsc/sch5147/acpi: Convert superio.asl to ASL 2.0 syntax

Change-Id: I509b76dbdbdee8a6287fc7d877c9f6e3c6a9068b
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45992
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/superio/smsc/sch5147/acpi/superio.asl
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/superio/smsc/sch5147/acpi/superio.asl b/src/superio/smsc/sch5147/acpi/superio.asl
index a8a24a5..d5040e7 100644
--- a/src/superio/smsc/sch5147/acpi/superio.asl
+++ b/src/superio/smsc/sch5147/acpi/superio.asl
@@ -124,7 +124,7 @@
    Method (_DIS)
    {
    	ENTER_CONFIG_MODE (SUPERIO_KBC_LDN)
-		  Store (Zero, PNP_DEVICE_ACTIVE)
+		  PNP_DEVICE_ACTIVE = 0
    	EXIT_CONFIG_MODE ()
    	#if defined(SUPERIO_KBC_PS2LDN)
    	Notify (SUPERIO_ID(PS2, SUPERIO_KBC_PS2LDN), 1)
@@ -169,7 +169,7 @@
    	})
    	ENTER_CONFIG_MODE (SUPERIO_KBC_LDN)
    	  PNP_WRITE_IRQ(PNP_IRQ0, Arg0, IR0)
-		  Store (One, PNP_DEVICE_ACTIVE)
+		  PNP_DEVICE_ACTIVE = 1
    	EXIT_CONFIG_MODE ()
    	Notify (SUPERIO_ID(PS2, SUPERIO_KBC_LDN), 1)
    }