Change in coreboot[master]: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region

Change-Id: I1b689896fcf255b795b27d7a7163849d6dfdb00e
Signed-off-by: Felix Held 
---
M src/soc/amd/stoneyridge/memmap.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40506/1

diff --git a/src/soc/amd/stoneyridge/memmap.c b/src/soc/amd/stoneyridge/memmap.c
index 0c8d9c0..34ddcb3 100644
--- a/src/soc/amd/stoneyridge/memmap.c
+++ b/src/soc/amd/stoneyridge/memmap.c
@@ -32,7 +32,7 @@
    if (CONFIG(ACPI_BERT))
    	*start = cbmem_top();
    else
-		start = NULL;
+		*start = NULL;
    *size = BERT_REGION_MAX_SIZE;
 }

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

Patch Set 1:

That code path likely hadn't seen a compiler

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

Patch Set 1: Code-Review+2

Compiler sees it all, it's only garbage collected later.
NULL is just not very type safe ;)

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40506/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40506/1//COMMIT_MSG@7 
PS1, Line 7: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
Please be more specific.

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded a new patch set (#2) to the change originally created by Felix Held. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region

Changing the local pointer "start" has no effect.
Changing the value it points to has.

Change-Id: I1b689896fcf255b795b27d7a7163849d6dfdb00e
Signed-off-by: Felix Held 
---
M src/soc/amd/stoneyridge/memmap.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/40506/2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40506/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40506/1//COMMIT_MSG@7 
PS1, Line 7: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
> Please be more specific.

Done

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40506 )

Change subject: soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region
......................................................................

soc/amd/stoneyridge/memmap: fix bug in bert_reserved_region

Changing the local pointer "start" has no effect.
Changing the value it points to has.

Change-Id: I1b689896fcf255b795b27d7a7163849d6dfdb00e
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40506
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M src/soc/amd/stoneyridge/memmap.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/soc/amd/stoneyridge/memmap.c b/src/soc/amd/stoneyridge/memmap.c
index 0c8d9c0..34ddcb3 100644
--- a/src/soc/amd/stoneyridge/memmap.c
+++ b/src/soc/amd/stoneyridge/memmap.c
@@ -32,7 +32,7 @@
    if (CONFIG(ACPI_BERT))
    	*start = cbmem_top();
    else
-		start = NULL;
+		*start = NULL;
    *size = BERT_REGION_MAX_SIZE;
 }