Attention is currently required from: Felix Singer, Martin L Roth.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80436?usp=email )
Change subject: lint: Make lint work on Darwin
......................................................................
Patch Set 2:
(2 comments)
File util/lint/lint:
https://review.coreboot.org/c/coreboot/+/80436/comment/ad50cb26_403513ba :
PS1, Line 25: # Look if we have getopt. If not, build it.
Could you move these lines below junit_write()? Then the functions stay in line.
Done
https://review.coreboot.org/c/coreboot/+/80436/comment/0d898f29_6e21c979 :
PS1, Line 29: --
This seems wrong here. The double dash is still present below.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80436?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife26083d2de080af9ed3d509945720051ca14bd7
Gerrit-Change-Number: 80436
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Sat, 02 Mar 2024 01:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment