Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO config
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37427/18//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37427/18//COMMIT_MSG@19
PS18, Line 19: Build and boot tigerlake rvp board
Did you verify that the mapping for each community works as expected? i.e. […]
Yes. I had verified that after setting the gpe from devicetree the GPP_EN register for that community gets updated setting that specific bit.
from the iotools i checked that GPE_EN register for that community is updated with that specific bit set to 1.
https://review.coreboot.org/c/coreboot/+/37427/20//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37427/20//COMMIT_MSG@22
PS20, Line 22: GPE_EN
Shouldn't GPE_STS be checked?
STS gets cleared by OS after servicing if there is an event handler for that GPE. I Will try to check if a setting a gpe enable bit and manually toggling the GPIO Tx.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa
Gerrit-Change-Number: 37427
Gerrit-PatchSet: 21
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 Jan 2020 07:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment