[M] Change in coreboot[main]: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper

[Naresh Solanki (Code Review)]

Attention is currently required from: Angel Pons, Felix Held, Jérémy Compostella, Maximilian Brune, Patrick Rudolph, Paul Menzel.

Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )

Change subject: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper
......................................................................

Patch Set 4:

(2 comments)

File src/soc/amd/glinda/cpu.c:

https://review.coreboot.org/c/coreboot/+/85640/comment/c0b827f4_7badd6bf?usp... :
PS4, Line 39: 	s
> maybe add a comment like: `get local APIC ID` at the end of the line. […]

Nope. it doesn't works. lapicid doesn't reflect the physical core id

https://review.coreboot.org/c/coreboot/+/85640/comment/10ac30e3_bdc60fba?usp... :
PS4, Line 41: __fls(info->num_cores_shared-1);
> it may make sense to use `log2` directly, since that is also what is used in the AMD64 specification […]

Yes __fls it uses log2.