Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42983 )
Change subject: drivers/pci80/tpm/tis: Add x86_64 support ......................................................................
drivers/pci80/tpm/tis: Add x86_64 support
Fix integer with different size to pointer conversion on x86_64.
Change-Id: Ic06a32d549b694310f4c724246f28fed15acf83f Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/drivers/pc80/tpm/tis.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42983/1
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index e18f9af..4fbb09e 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -44,7 +44,7 @@
/* the macro accepts the locality value, but only locality 0 is operational */ #define TIS_REG(LOCALITY, REG) \ - (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG) + (void *)(uintptr_t)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG)
/* hardware registers' offsets */ #define TIS_REG_ACCESS 0x0
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42983 )
Change subject: drivers/pci80/tpm/tis: Add x86_64 support ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42983/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42983/1//COMMIT_MSG@7 PS1, Line 7: pci80 pc80
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Christian Walter, Angel Pons, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42983
to look at the new patch set (#2).
Change subject: drivers/pc80/tpm/tis: Add x86_64 support ......................................................................
drivers/pc80/tpm/tis: Add x86_64 support
Fix integer with different size to pointer conversion on x86_64.
Change-Id: Ic06a32d549b694310f4c724246f28fed15acf83f Signed-off-by: Patrick Rudolph siro@das-labor.org --- M src/drivers/pc80/tpm/tis.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42983/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42983 )
Change subject: drivers/pc80/tpm/tis: Add x86_64 support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42983/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42983/1//COMMIT_MSG@7 PS1, Line 7: pci80
pc80
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42983 )
Change subject: drivers/pc80/tpm/tis: Add x86_64 support ......................................................................
Patch Set 2: Code-Review+1
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42983 )
Change subject: drivers/pc80/tpm/tis: Add x86_64 support ......................................................................
Patch Set 2: Code-Review+2
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42983 )
Change subject: drivers/pc80/tpm/tis: Add x86_64 support ......................................................................
drivers/pc80/tpm/tis: Add x86_64 support
Fix integer with different size to pointer conversion on x86_64.
Change-Id: Ic06a32d549b694310f4c724246f28fed15acf83f Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/42983 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/pc80/tpm/tis.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index e18f9af..4fbb09e 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -44,7 +44,7 @@
/* the macro accepts the locality value, but only locality 0 is operational */ #define TIS_REG(LOCALITY, REG) \ - (void *)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG) + (void *)(uintptr_t)(CONFIG_TPM_TIS_BASE_ADDRESS + (LOCALITY << 12) + REG)
/* hardware registers' offsets */ #define TIS_REG_ACCESS 0x0
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)