Attention is currently required from: Angel Pons.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73869 )
Change subject: mb/acer/aspire_vn7_572g: Fix internal speakers again ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73869/comment/b03b0e4c_6ce6a4e5 PS1, Line 15: Further investigation required to know why this works.
Do you have a coreboot log before and after this change?
There's no change in the logs about Azalia, which makes sense. The verbs are simply sent to the HDA's "immediate command" register. I may need to see if the HDA device or its BAR have some detailed status reporting register. I don't fully expect it though.
Patchset:
PS1:
Need to retest the display (HDMI) audio now.
Noticed speakers crackle once again, but seems fine now. Will continue watching.
I've assumed the board is fine. The speaker hardware part should be fine, the firmware should be fine: because unless I'm missing some other module in my analysis, this table is as correct as the vendor's, since it's what is sent to the hardware.
-
Benjamin Doron (Code Review)