Change in coreboot[master]: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27221 )
Change subject: mb/google/poppy/variants/nocturne: fix FPMCU IRQ sensitivity ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... PS1, Line 134: NONE I suggest a 20k internal pd, see comment below.
https://review.coreboot.org/#/c/27221/1/src/mainboard/google/poppy/variants/... PS1, Line 138: NONE a 20k pulldown here would help for preEVT2 devices (preEVT2 is missing a pd in hw on this line; EVT2 will have a hardware pd on this line, but I think a 20k pd here should allow this to work with both preEVT2 and EVT2 devices)
-
Nick Vaccaro (Code Review)