Change in coreboot[master]: lenovo/x230: introduce FHD variant - coreboot-gerrit

20 Jun 2020


      Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 10:
...
I finally got around to testing this patch.  Seems to be working well for the most part.  I just want to confirm that the brightness adjustment is still is not functional. Based on the comments, it is waiting on Nitrocaster to release the firmware to possibly find a software workaround for it?  Is this correct?
No. brightness control is working, but there might be some artifacts from the ADC. When changing the brightness in a smooth way it shows you high brightness steps.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 10
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC:  Felix Singer felixsinger@posteo.net
Gerrit-CC: Aleksei Kharlamov derlafff@ya.ru
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen holger@layer-acht.org
Gerrit-CC: Kilian Neuner cb@9-r.net
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev zl29ah@gmail.com
Gerrit-CC: Tom Hiller thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: clayton craft
Gerrit-Comment-Date: Sat, 20 Jun 2020 20:30:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment