Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
util/mb/google: add templates for dedede boards
Add template directories for the Waddledee and Waddledoo reference boards of the Dedede baseboard.
BUG=b:157183582 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ida70a44097334991a93fec8f4933d7f6e39a187b --- A util/mainboard/google/waddledee/template/Makefile.inc A util/mainboard/google/waddledee/template/include/variant/ec.h A util/mainboard/google/waddledee/template/include/variant/gpio.h A util/mainboard/google/waddledee/template/memory.c A util/mainboard/google/waddledee/template/overridetree.cb A util/mainboard/google/waddledoo/template/Makefile.inc A util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl A util/mainboard/google/waddledoo/template/include/variant/ec.h A util/mainboard/google/waddledoo/template/include/variant/gpio.h A util/mainboard/google/waddledoo/template/memory.c A util/mainboard/google/waddledoo/template/overridetree.cb 11 files changed, 195 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41640/1
diff --git a/util/mainboard/google/waddledee/template/Makefile.inc b/util/mainboard/google/waddledee/template/Makefile.inc new file mode 100644 index 0000000..4643cb2 --- /dev/null +++ b/util/mainboard/google/waddledee/template/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +SPD_SOURCES += empty #0b0000 + +romstage-y += memory.c diff --git a/util/mainboard/google/waddledee/template/include/variant/ec.h b/util/mainboard/google/waddledee/template/include/variant/ec.h new file mode 100644 index 0000000..6e12175 --- /dev/null +++ b/util/mainboard/google/waddledee/template/include/variant/ec.h @@ -0,0 +1,12 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/util/mainboard/google/waddledee/template/include/variant/gpio.h b/util/mainboard/google/waddledee/template/include/variant/gpio.h new file mode 100644 index 0000000..c7e4605 --- /dev/null +++ b/util/mainboard/google/waddledee/template/include/variant/gpio.h @@ -0,0 +1,12 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/util/mainboard/google/waddledee/template/memory.c b/util/mainboard/google/waddledee/template/memory.c new file mode 100644 index 0000000..2c81650 --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory.c @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/variants.h> +#include <baseboard/gpio.h> +#include <ec/google/chromeec/ec.h> +#include <gpio.h> + +bool variant_mem_is_half_populated(void) +{ + uint32_t board_ver; + + /* On boards where board version is populated, ram strap is also populated */ + if (!google_chromeec_get_board_version(&board_ver)) + return !gpio_get(GPIO_MEM_CH_SEL); + + return false; +} diff --git a/util/mainboard/google/waddledee/template/overridetree.cb b/util/mainboard/google/waddledee/template/overridetree.cb new file mode 100644 index 0000000..404024b --- /dev/null +++ b/util/mainboard/google/waddledee/template/overridetree.cb @@ -0,0 +1,42 @@ +chip soc/intel/jasperlake + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + }, + }" + + device domain 0 on + device pci 15.0 on end + end +end diff --git a/util/mainboard/google/waddledoo/template/Makefile.inc b/util/mainboard/google/waddledoo/template/Makefile.inc new file mode 100644 index 0000000..c1e68ce --- /dev/null +++ b/util/mainboard/google/waddledoo/template/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +SPD_SOURCES = empty #0b0000 + +romstage-y += memory.c diff --git a/util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl b/util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl new file mode 100644 index 0000000..318b0de --- /dev/null +++ b/util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/acpi/camera.asl> diff --git a/util/mainboard/google/waddledoo/template/include/variant/ec.h b/util/mainboard/google/waddledoo/template/include/variant/ec.h new file mode 100644 index 0000000..6e12175 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/include/variant/ec.h @@ -0,0 +1,12 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/util/mainboard/google/waddledoo/template/include/variant/gpio.h b/util/mainboard/google/waddledoo/template/include/variant/gpio.h new file mode 100644 index 0000000..c7e4605 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/include/variant/gpio.h @@ -0,0 +1,12 @@ +/* + * + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/util/mainboard/google/waddledoo/template/memory.c b/util/mainboard/google/waddledoo/template/memory.c new file mode 100644 index 0000000..2c81650 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory.c @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/variants.h> +#include <baseboard/gpio.h> +#include <ec/google/chromeec/ec.h> +#include <gpio.h> + +bool variant_mem_is_half_populated(void) +{ + uint32_t board_ver; + + /* On boards where board version is populated, ram strap is also populated */ + if (!google_chromeec_get_board_version(&board_ver)) + return !gpio_get(GPIO_MEM_CH_SEL); + + return false; +} diff --git a/util/mainboard/google/waddledoo/template/overridetree.cb b/util/mainboard/google/waddledoo/template/overridetree.cb new file mode 100644 index 0000000..69ea1e1 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/overridetree.cb @@ -0,0 +1,58 @@ +chip soc/intel/jasperlake + + # USB Port Configuration + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 66, + .fall_time_ns = 90, + .data_hold_time_ns = 350, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 176, + .scl_hcnt = 95, + .sda_hold = 36, + } + }, + }" + device domain 0 on + device pci 14.0 on end + device pci 15.0 on end + device pci 15.2 on end + device pci 1c.7 on end + device pci 19.0 on end + device pci 1f.3 on end + end +end
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 1: /* : * : * : * SPDX-License-Identifier: GPL-2.0-or-later : */ I feel this can be a single line comment.
It appears this way in the existing files which have been going through some clean-ups.
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory.c:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 18: This file can be removed. The concerned strap GPIO_MEM_CH_SEL will be stuffed in all the upcoming reference and variant boards. A weak override function to read the GPIO has been implemented in variants/baseboard/memory.c
Also this file can be removed in the makefile. Same comment applies for waddledoo as well.
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 27: rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350 The rise time, fall time and data hold time may require tuning based on individual variant boards. So we can remove them.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Karthik Ramasubramanian, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41640
to look at the new patch set (#2).
Change subject: util/mb/google: add templates for dedede boards ......................................................................
util/mb/google: add templates for dedede boards
Add template directories for the Waddledee and Waddledoo reference boards of the Dedede baseboard.
BUG=b:157183582 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ida70a44097334991a93fec8f4933d7f6e39a187b --- A util/mainboard/google/waddledee/template/Makefile.inc A util/mainboard/google/waddledee/template/include/variant/ec.h A util/mainboard/google/waddledee/template/include/variant/gpio.h A util/mainboard/google/waddledee/template/overridetree.cb A util/mainboard/google/waddledoo/template/Makefile.inc A util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl A util/mainboard/google/waddledoo/template/include/variant/ec.h A util/mainboard/google/waddledoo/template/include/variant/gpio.h A util/mainboard/google/waddledoo/template/overridetree.cb 9 files changed, 161 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41640/2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 1: /* : * : * : * SPDX-License-Identifier: GPL-2.0-or-later : */
I feel this can be a single line comment. […]
Done
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory.c:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 18:
This file can be removed. […]
Done
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41640/1/util/mainboard/google/waddl... PS1, Line 27: rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350
The rise time, fall time and data hold time may require tuning based on individual variant boards. […]
Done
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Karthik Ramasubramanian, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41640
to look at the new patch set (#3).
Change subject: util/mb/google: add templates for dedede boards ......................................................................
util/mb/google: add templates for dedede boards
Add template directories for the Waddledee and Waddledoo reference boards of the Dedede baseboard.
BUG=b:157183582 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ida70a44097334991a93fec8f4933d7f6e39a187b --- A util/mainboard/google/waddledee/template/Makefile.inc A util/mainboard/google/waddledee/template/include/variant/ec.h A util/mainboard/google/waddledee/template/include/variant/gpio.h A util/mainboard/google/waddledee/template/overridetree.cb A util/mainboard/google/waddledoo/template/Makefile.inc A util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl A util/mainboard/google/waddledoo/template/include/variant/ec.h A util/mainboard/google/waddledoo/template/include/variant/gpio.h A util/mainboard/google/waddledoo/template/overridetree.cb 9 files changed, 157 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41640/3
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Karthik Ramasubramanian, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41640
to look at the new patch set (#4).
Change subject: util/mb/google: add templates for dedede boards ......................................................................
util/mb/google: add templates for dedede boards
Add template directories for the Waddledee and Waddledoo reference boards of the Dedede baseboard.
BUG=b:157183582 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ida70a44097334991a93fec8f4933d7f6e39a187b --- A util/mainboard/google/waddledee/template/Makefile.inc A util/mainboard/google/waddledee/template/include/variant/ec.h A util/mainboard/google/waddledee/template/include/variant/gpio.h A util/mainboard/google/waddledee/template/overridetree.cb A util/mainboard/google/waddledoo/template/Makefile.inc A util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl A util/mainboard/google/waddledoo/template/include/variant/ec.h A util/mainboard/google/waddledoo/template/include/variant/gpio.h A util/mainboard/google/waddledoo/template/overridetree.cb 9 files changed, 149 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41640/4
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... PS4, Line 4: SPDX-License-Identifier: GPL-2.0-or-later Nit: Update it as a single line comment.
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... PS4, Line 4: SPDX-License-Identifier: GPL-2.0-or-later Nit: Update it as a single line comment.
Otherwise LGTM.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marco Chen, Karthik Ramasubramanian, Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41640
to look at the new patch set (#5).
Change subject: util/mb/google: add templates for dedede boards ......................................................................
util/mb/google: add templates for dedede boards
Add template directories for the Waddledee and Waddledoo reference boards of the Dedede baseboard.
BUG=b:157183582 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ida70a44097334991a93fec8f4933d7f6e39a187b --- A util/mainboard/google/waddledee/template/Makefile.inc A util/mainboard/google/waddledee/template/include/variant/ec.h A util/mainboard/google/waddledee/template/include/variant/gpio.h A util/mainboard/google/waddledee/template/overridetree.cb A util/mainboard/google/waddledoo/template/Makefile.inc A util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl A util/mainboard/google/waddledoo/template/include/variant/ec.h A util/mainboard/google/waddledoo/template/include/variant/gpio.h A util/mainboard/google/waddledoo/template/overridetree.cb 9 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41640/5
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... PS4, Line 4: SPDX-License-Identifier: GPL-2.0-or-later
Nit: Update it as a single line comment.
Done
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/41640/4/util/mainboard/google/waddl... PS4, Line 4: SPDX-License-Identifier: GPL-2.0-or-later
Nit: Update it as a single line comment. […]
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 5: Code-Review+2
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
util/mb/google: add templates for dedede boards
Add template directories for the Waddledee and Waddledoo reference boards of the Dedede baseboard.
BUG=b:157183582 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ida70a44097334991a93fec8f4933d7f6e39a187b Reviewed-on: https://review.coreboot.org/c/coreboot/+/41640 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- A util/mainboard/google/waddledee/template/Makefile.inc A util/mainboard/google/waddledee/template/include/variant/ec.h A util/mainboard/google/waddledee/template/include/variant/gpio.h A util/mainboard/google/waddledee/template/overridetree.cb A util/mainboard/google/waddledoo/template/Makefile.inc A util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl A util/mainboard/google/waddledoo/template/include/variant/ec.h A util/mainboard/google/waddledoo/template/include/variant/gpio.h A util/mainboard/google/waddledoo/template/overridetree.cb 9 files changed, 141 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/util/mainboard/google/waddledee/template/Makefile.inc b/util/mainboard/google/waddledee/template/Makefile.inc new file mode 100644 index 0000000..6861194 --- /dev/null +++ b/util/mainboard/google/waddledee/template/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +SPD_SOURCES += empty #0b0000 diff --git a/util/mainboard/google/waddledee/template/include/variant/ec.h b/util/mainboard/google/waddledee/template/include/variant/ec.h new file mode 100644 index 0000000..08870e0 --- /dev/null +++ b/util/mainboard/google/waddledee/template/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/util/mainboard/google/waddledee/template/include/variant/gpio.h b/util/mainboard/google/waddledee/template/include/variant/gpio.h new file mode 100644 index 0000000..9078664 --- /dev/null +++ b/util/mainboard/google/waddledee/template/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/util/mainboard/google/waddledee/template/overridetree.cb b/util/mainboard/google/waddledee/template/overridetree.cb new file mode 100644 index 0000000..404024b --- /dev/null +++ b/util/mainboard/google/waddledee/template/overridetree.cb @@ -0,0 +1,42 @@ +chip soc/intel/jasperlake + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + }, + }" + + device domain 0 on + device pci 15.0 on end + end +end diff --git a/util/mainboard/google/waddledoo/template/Makefile.inc b/util/mainboard/google/waddledoo/template/Makefile.inc new file mode 100644 index 0000000..fd8d126 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/Makefile.inc @@ -0,0 +1,3 @@ +## SPDX-License-Identifier: GPL-2.0-or-later + +SPD_SOURCES = empty #0b0000 diff --git a/util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl b/util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl new file mode 100644 index 0000000..318b0de --- /dev/null +++ b/util/mainboard/google/waddledoo/template/include/variant/acpi/camera.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/acpi/camera.asl> diff --git a/util/mainboard/google/waddledoo/template/include/variant/ec.h b/util/mainboard/google/waddledoo/template/include/variant/ec.h new file mode 100644 index 0000000..08870e0 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef MAINBOARD_EC_H +#define MAINBOARD_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/util/mainboard/google/waddledoo/template/include/variant/gpio.h b/util/mainboard/google/waddledoo/template/include/variant/gpio.h new file mode 100644 index 0000000..9078664 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +#include <baseboard/gpio.h> + +#endif /* MAINBOARD_GPIO_H */ diff --git a/util/mainboard/google/waddledoo/template/overridetree.cb b/util/mainboard/google/waddledoo/template/overridetree.cb new file mode 100644 index 0000000..69ea1e1 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/overridetree.cb @@ -0,0 +1,58 @@ +chip soc/intel/jasperlake + + # USB Port Configuration + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera + + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Trackpad | + #| I2C1 | Digitizer | + #| I2C2 | Touchscreen | + #| I2C3 | Camera | + #| I2C4 | Audio | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 66, + .fall_time_ns = 90, + .data_hold_time_ns = 350, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[4] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 176, + .scl_hcnt = 95, + .sda_hold = 36, + } + }, + }" + device domain 0 on + device pci 14.0 on end + device pci 15.0 on end + device pci 15.2 on end + device pci 1c.7 on end + device pci 19.0 on end + device pci 1f.3 on end + end +end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41640 )
Change subject: util/mb/google: add templates for dedede boards ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4504 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4503 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4502 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4501
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Paul Fagerburg (Code Review)