Change in coreboot[master]: drivers/usb: Fix SSDT table to use _STR instead of _DDN

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Edward O'Callaghan (Code Review)

20 Jan 2020 20 Jan '20

8:03 a.m.

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38476 )

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

drivers/usb: Fix SSDT table to use _STR instead of _DDN

As recommend by the new testament (ACPI spec).

Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/drivers/usb/acpi/usb_acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/38476/1

diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index a312c88..66f6ce0 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -44,8 +44,8 @@ return;

acpigen_write_scope(path); - if (config->desc) - acpigen_write_name_string("_DDN", config->desc); + if (config->desc) { + acpigen_write_name_string("_STR", config->desc); acpigen_write_upc(config->type);

if (config->use_custom_pld) {

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Edward O'Callaghan (Code Review)

20 Jan 20 Jan

8:04 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38476 )

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

Patch Set 1:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Gerrit-Change-Number: 38476 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Comment-Date: Mon, 20 Jan 2020 08:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

8:05 a.m.

Hello Daniel Kurtz,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38476

to look at the new patch set (#2).

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

drivers/usb: Fix SSDT table to use _STR instead of _DDN

As recommend by the new testament (ACPI spec).

Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/drivers/usb/acpi/usb_acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/38476/2

Patrick Rudolph (Code Review)

5:20 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38476 )

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

Patch Set 2:

(1 comment)

This change is ready for review.

https://review.coreboot.org/c/coreboot/+/38476/2/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:

https://review.coreboot.org/c/coreboot/+/38476/2/src/drivers/usb/acpi/usb_ac... PS2, Line 48: acpigen_write_name_string("_STR You must use acpigen_write_name_unicode as _STR is not ASCII

-- To view, visit https://review.coreboot.org/c/coreboot/+/38476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Gerrit-Change-Number: 38476 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 Jan 2020 17:20:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

21 Jan 21 Jan

12:33 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38476 )

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

Patch Set 2:

...

Patch Set 2:

(1 comment)

This change is ready for review.

This patch was marked WIP?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Gerrit-Change-Number: 38476 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jan 2020 00:33:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

5 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38476 )

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

Patch Set 2:

...

Patch Set 2:

...
Patch Set 2:

(1 comment)

This change is ready for review.

This patch was marked WIP?

Looks like a Gerrit bug. It's set to review once you comment.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Gerrit-Change-Number: 38476 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jan 2020 05:00:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

8:42 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38476 )

Change subject: drivers/usb: Fix SSDT table to use _STR instead of _DDN ......................................................................

Patch Set 2:

...

Patch Set 2:

...
Patch Set 2:

...
Patch Set 2:

(1 comment)

This change is ready for review.

This patch was marked WIP?

Looks like a Gerrit bug. It's set to review once you comment.

It's not a gerrit bug it is just you are starting a review by commenting.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38476 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5ee2ea73cea702bd5ba26a2ee8949e4b117fbfa Gerrit-Change-Number: 38476 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph siro@das-labor.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jan 2020 08:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1713

days inactive

1714

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Edward O'Callaghan (Code Review)
Patrick Rudolph (Code Review)