Attention is currently required from: Jason Glenesk, Raul Rangel, Michał Żygowski, Frans Hendriks, Matt DeVillier, Christian Walter, Julius Werner, Krystian Hebel, Fred Reitberger, Yu-Ping Wu, Felix Held.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69160 )
Change subject: security/tpm: resolve conflicts in TSS implementations ......................................................................
Patch Set 9:
(6 comments)
File src/security/tpm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/69160/comment/1d5ffc47_84235feb PS8, Line 13: ramstage-y += tss/tss.c : romstage-y += tss/tss.c : bootblock-y += tss/tss.c : verstage-y += tss/tss.c : postcar-y += tss/tss.c
Can use `all-y` for all classes (bootblock verstage romstage postcar ramstage).
Done
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/69160/comment/d7500f72_3fe38986 PS8, Line 19: #include <security/tpm/tis.h>
Sort the headers.
Done
File src/security/tpm/tss/tss.c:
https://review.coreboot.org/c/coreboot/+/69160/comment/75a980eb_7bc372ea PS8, Line 17: chose
choose
Done
https://review.coreboot.org/c/coreboot/+/69160/comment/deb1efbf_f30cada1 PS8, Line 20:
Extra blank line.
Done
https://review.coreboot.org/c/coreboot/+/69160/comment/9d51d612_00bbfe47 PS8, Line 22: VB2_SUCCESS
Not related to your change, but why does this function return VB2_*? Can't we just return something […]
Its clients check for `VB2_*`. I think it was introduced for vboot and hence uses its error codes.
https://review.coreboot.org/c/coreboot/+/69160/comment/a7e2fd17_cb042827 PS8, Line 37: if (CONFIG(TPM1) && family == TPM_1) : return tlcl1_startup(); : if (CONFIG(TPM2) && family == TPM_2) : return tlcl2_startup(); : return TPM_E_INTERNAL_INCONSISTENCY;
I wonder if we can define a macro to simplify the functions below: […]
Done
-
Sergii Dmytruk (Code Review)