Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62766 )
Change subject: soc/intel/tgl: move DIMM_SPD_SIZE from mb to SoC Kconfig ......................................................................
soc/intel/tgl: move DIMM_SPD_SIZE from mb to SoC Kconfig
All TGL mainboards are setting DIMM_SPD_SIZE to 512. Thus, default to 512 in the SoC Kconfig and drop it from the mainboard Kconfigs.
Change-Id: I9fd947b61c984e10bd5fba20b73280b08623a008 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/62766 Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Tim Crawford tcrawford@system76.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/system76/darp7/Kconfig M src/mainboard/system76/galp5/Kconfig M src/mainboard/system76/gaze16/Kconfig M src/mainboard/system76/lemp10/Kconfig M src/mainboard/system76/oryp8/Kconfig M src/soc/intel/tigerlake/Kconfig 10 files changed, 3 insertions(+), 27 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Tim Crawford: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 492bcbb..eb27796 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -36,9 +36,6 @@ select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_SWITCH_ON
-config DIMM_SPD_SIZE - default 512 - config DEVICETREE default "variants/baseboard/devicetree.cb"
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index eb8f176..4f83d1c 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -144,9 +144,6 @@ select SAR_ENABLE select USE_SAR
-config DIMM_SPD_SIZE - default 512 - config DEVICETREE default "variants/baseboard/devicetree.cb"
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 9e63f2c..8a4c9ad 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -60,9 +60,6 @@ config DEVICETREE default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-config DIMM_SPD_SIZE - default 512 - choice prompt "ON BOARD EC" default TGL_CHROME_EC diff --git a/src/mainboard/starlabs/labtop/Kconfig b/src/mainboard/starlabs/labtop/Kconfig index 0f7d108..f8a5bc7 100644 --- a/src/mainboard/starlabs/labtop/Kconfig +++ b/src/mainboard/starlabs/labtop/Kconfig @@ -46,9 +46,6 @@ config DEVICETREE default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
-config DIMM_SPD_SIZE - default 512 - config DRIVER_TPM_SPI_CHIP default 2
diff --git a/src/mainboard/system76/darp7/Kconfig b/src/mainboard/system76/darp7/Kconfig index 75d8e1d..960e5ae 100644 --- a/src/mainboard/system76/darp7/Kconfig +++ b/src/mainboard/system76/darp7/Kconfig @@ -44,9 +44,6 @@ config CONSOLE_POST default y
-config DIMM_SPD_SIZE - default 512 - config POST_DEVICE default n
diff --git a/src/mainboard/system76/galp5/Kconfig b/src/mainboard/system76/galp5/Kconfig index bb4b2ea..98e32f7 100644 --- a/src/mainboard/system76/galp5/Kconfig +++ b/src/mainboard/system76/galp5/Kconfig @@ -43,9 +43,6 @@ config CONSOLE_POST default y
-config DIMM_SPD_SIZE - default 512 - config ONBOARD_VGA_IS_PRIMARY default y
diff --git a/src/mainboard/system76/gaze16/Kconfig b/src/mainboard/system76/gaze16/Kconfig index daf3302..cc96d5f 100644 --- a/src/mainboard/system76/gaze16/Kconfig +++ b/src/mainboard/system76/gaze16/Kconfig @@ -55,9 +55,6 @@ config CONSOLE_POST default y
-config DIMM_SPD_SIZE - default 512 - config ONBOARD_VGA_IS_PRIMARY default y
diff --git a/src/mainboard/system76/lemp10/Kconfig b/src/mainboard/system76/lemp10/Kconfig index fc8abba..a732425 100644 --- a/src/mainboard/system76/lemp10/Kconfig +++ b/src/mainboard/system76/lemp10/Kconfig @@ -44,9 +44,6 @@ config CONSOLE_POST default y
-config DIMM_SPD_SIZE - default 512 - config POST_DEVICE default n
diff --git a/src/mainboard/system76/oryp8/Kconfig b/src/mainboard/system76/oryp8/Kconfig index 958cda8..8e65b70 100644 --- a/src/mainboard/system76/oryp8/Kconfig +++ b/src/mainboard/system76/oryp8/Kconfig @@ -49,9 +49,6 @@ config DIMM_MAX default 4
-config DIMM_SPD_SIZE - default 512 - config ONBOARD_VGA_IS_PRIMARY default y
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 6d20112..2b673cab 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -94,6 +94,9 @@ default 16 if SOC_INTEL_TIGERLAKE_PCH_H default 8
+config DIMM_SPD_SIZE + default 512 + config DCACHE_RAM_BASE default 0xfef00000
-
Felix Held (Code Review)