Attention is currently required from: Lance Zhao, Martin Roth, Patrick Rudolph. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49492 )
Change subject: soc/intel/baytrail: Drop runtime ACPI mode change via SMI ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
depthcharge still have the "legacy switch" option there, I don't think we can simply revert the chan […]
No tests so far this is for discussion and identifying the purpose of this particular SMI.
So I was at first wondering why only baytrail implements this? Are there more in ChromeOS repos but not upstreamed? If it was important to have xx_acpi_mode=0 it shouldl have been enforced with CONFIG(PAYLOAD_SEABIOS).
Those were my questions at first. After another look I figured only google/rambi has xx_acpi_mode=1 entries and bostentech/byt4 does not.
And for soc/intel/braswell majority of boards have set _acpi_mode=0 in the devicetree already, except for some in intel/strago and google/cyan.
I did not check thoroughly what this ACPI mode is? Making the device non-responsive to PCI config queries while maintaining/decoding the already configured BARs? And using ACPI _UID _HID instead of PCI VID/DID for driver probing?
-
Kyösti Mälkki (Code Review)