[M] Change in coreboot[main]: drivers/intel/fsp2_0: Add FSP 2.4 support - coreboot-gerrit

31 Jan 2024


      Attention is currently required from: Andrey Petrov, Bora Guvendik, Jérémy Compostella, Ronak Kanabar, Wonkyu Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80275?usp=email )
Change subject: drivers/intel/fsp2_0: Add FSP 2.4 support
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3: 
quick feedback
1. This CL doesn't mentioned the test vehicle used to verify
2. specify the FSP 2.4 spec link
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/80275/comment/05ef0e81_1a274994 :
PS3, Line 58: default n if PLATFORM_USES_FSP2_4
ideally this config can be only select if `depends on !PLATFORM_USES_FSP2_4`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80275?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa97
Gerrit-Change-Number: 80275
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Comment-Date: Wed, 31 Jan 2024 18:24:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment