Attention is currently required from: Hung-Te Lin, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63252 )
Change subject: soc/mediatek: Fill coreboot table with PCIe info
......................................................................
Patch Set 12:
(2 comments)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/63252/comment/c62436d8_fdf12d15
PS12, Line 216: if (pci_root_bus()) {
Rewrite as
if (!pci_root_bus())
return CB_ERR;
...
https://review.coreboot.org/c/coreboot/+/63252/comment/bd966f10_4f804715
PS12, Line 217: pcie->ctrl_base = mtk_pcie_get_controller_base(0);
Set other fields to 0 (using memset)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2988694f60aac9cbfc09ef9a26d47e01c004406
Gerrit-Change-Number: 63252
Gerrit-PatchSet: 12
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 07:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment