Change in coreboot[master]: mb/google/octopus: do LPC/eSPI pad configuration at board-level - coreboot-gerrit

16 Jan 2021


      Attention is currently required from: Michael Niewöhner, Karthik Ramasubramanian.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49411 )
Change subject: mb/google/octopus: do LPC/eSPI pad configuration at board-level
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/octopus/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49411/comment/a6056a3e_ebc1b88d 
PS1, Line 13: 	pads = variant_early_bootblock_gpio_table(&num);
...
Oh, I thought I had commented that alreay... strange. […]
Maybe also not a bad idea to give it a name that relates to its purpose,
e.g. octopus_pre_ec_gpio_table()?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie33bae481f430a1c4410a0a4e2b2a34a3e78adaa
Gerrit-Change-Number: 49411
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Sat, 16 Jan 2021 18:33:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment