Attention is currently required from: Angel Pons, Felix Held, Jérémy Compostella, Patrick Rudolph, Paul Menzel.
Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )
Change subject: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper
......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS3:
how common is this code? i'd expect this to not only be correct for glinda; not sure though if this […]
I dont have information about other SoC.
Commit Message:
https://review.coreboot.org/c/coreboot/+/85640/comment/f363a6ab_9a04c362?usp... :
PS3, Line 8:
Sure. […]
Done
File src/soc/amd/glinda/cpu.c:
https://review.coreboot.org/c/coreboot/+/85640/comment/d296b8fb_425dde54?usp... :
PS3, Line 43: fill_cpu_cache_info
I guess you imply that: […]
Done
https://review.coreboot.org/c/coreboot/+/85640/comment/f050311a_6691a10e?usp... :
PS3, Line 60: struct cpu_cache_info info_list
Yes.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85640?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6
Gerrit-Change-Number: 85640
Gerrit-PatchSet: 4
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 21 Feb 2025 21:32:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Naresh Solanki
naresh.solanki@9elements.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de